Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: .set command now handles spaces properly #1385

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

Hanicef
Copy link
Contributor

@Hanicef Hanicef commented Sep 24, 2018

I decided to fix this as I had nothing better for me.
Fixes #1384

@dgw dgw added the Bug Things to squish; generally used for issues label Sep 26, 2018
@dgw dgw added this to the 6.6.0 milestone Sep 26, 2018
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some research and was hoping to poke my head in here and point out a more elegant solution that used some magic to pull group 4 and everything after it, but alas, that's not possible with re (and I think only kludge-able with the PyPI regex module, which would also add another dependency).

This will probably do just fine. At some future point it might be nice for trigger to have an args property that tokenizes everything after the command (think argparse for Sopel commands), but that's a long way off if it even happens at all.

@dgw dgw merged commit c608837 into sopel-irc:master Dec 16, 2018
@dgw dgw added Bugfix Generally, PRs that reference (and fix) one or more issue(s) and removed Bug Things to squish; generally used for issues labels Jan 3, 2019
@dgw dgw mentioned this pull request Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin: .set command can't handle spaces
2 participants